Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support downloading result from external url #709

Merged
merged 9 commits into from
Feb 28, 2023
Merged

Support downloading result from external url #709

merged 9 commits into from
Feb 28, 2023

Conversation

daka1510
Copy link
Collaborator

@daka1510 daka1510 commented Feb 15, 2023 •
edited
Loading

Context

This PR adds support to resolve job results from an external URL. If the job response includes a url property, qiskit-ibm-runtime will fetch the result from the provided URL.

Test

Development branch can be installed via command below (replace commit hash with most recent commit in this branch)

pip install git+https://github.com/johker01/qiskit-ibm-runtime.git@7153c31cd3063d0248c67d63109a336a9991ddec

johker01 and others added 2 commits February 15, 2023 14:45
@johker01 @daka1510
download result from COS if raw_result contains url
cfc6065 
Co-authored-by: Daniel Kaulen <DKAULEN@de.ibm.com>
@daka1510 @johker01
add url resolution for streaming
705b884 
Co-authored-by: Johannes Kern <JOHKER@de.ibm.com>
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Feb 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4292105999

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 66.741%
Totals Coverage Status
Change from base Build 4277942110: 0.07%
Covered Lines: 3287
Relevant Lines: 4925
💛 - Coveralls

@johker01 johker01 marked this pull request as ready for review February 28, 2023 09:16
@johker01 johker01 marked this pull request as draft February 28, 2023 09:16
johker01 and others added 2 commits February 28, 2023 10:29
@johker01 @daka1510
move duplicate code into method
3d65c6d 
Co-authored-by: Daniel Kaulen <DKAULEN@de.ibm.com>
@johker01 @daka1510
add unit test for _download_external_result
60b92e3 
Co-authored-by: Daniel Kaulen <DKAULEN@de.ibm.com>
@johker01 johker01 requested review from kt474 and LucyXing February 28, 2023 10:39
@daka1510 daka1510 changed the title [work-in-progress] Support downloading result from external url Support downloading result from external url Feb 28, 2023
@daka1510 daka1510 marked this pull request as ready for review February 28, 2023 10:39
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Feb 28, 2023
kt474
kt474 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johker01 johker01 merged commit 0a62780 into Qiskit:main Feb 28, 2023
@johker01 johker01 deleted the cos_result_support branch February 28, 2023 16:10
@kt474 kt474 mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

@LucyXing LucyXing Awaiting requested review from LucyXing

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daka1510 @CLAassistant @coveralls @kt474 @johker01