Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error level default logic #751

Merged
merged 17 commits into from
Mar 24, 2023
Merged

Fix error level default logic #751

merged 17 commits into from
Mar 24, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 14, 2023

Summary

Details and comments

Fixes #750

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Mar 14, 2023
@coveralls
Copy link

coveralls commented Mar 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4507158708

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 66.7%
Totals Coverage Status
Change from base Build 4507156956: 0.09%
Covered Lines: 3309
Relevant Lines: 4961
💛 - Coveralls

@kt474 kt474 requested review from merav-aharoni and jyu00 March 14, 2023 21:41
jyu00
jyu00 requested changes Mar 14, 2023
View reviewed changes
qiskit_ibm_runtime/estimator.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/estimator.py Outdated Show resolved Hide resolved
test/integration/test_options.py Outdated Show resolved Hide resolved
@merav-aharoni merav-aharoni mentioned this pull request Mar 15, 2023
Closed
jyu00
jyu00 reviewed Mar 20, 2023
View reviewed changes
qiskit_ibm_runtime/estimator.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/estimator.py Outdated Show resolved Hide resolved
@kt474 kt474 requested a review from jyu00 March 23, 2023 03:04
jyu00
jyu00 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kt474 kt474 merged commit c9e6a3f into Qiskit:main Mar 24, 2023
@kt474 kt474 deleted the default-resilience branch March 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyu00 jyu00 jyu00 approved these changes

@merav-aharoni merav-aharoni Awaiting requested review from merav-aharoni

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resilience and optimization level 0 used by default
4 participants
@kt474 @coveralls @jyu00 @merav-aharoni