Accept all hierarchical options if given flatly #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untime into options_level
Pull Request Test Coverage Report for Build 4565427092
💛 - Coveralls |
merav-aharoni
changed the title
jyu00
added
the
Changelog: New Feature
kt474
approved these changes
Mar 30, 2023
frankharkins
pushed a commit
to frankharkins/qiskit-ibm-runtime
that referenced
this pull request
Apr 3, 2023
* Recognize first level options properly * Cleaned up Sampler code. Copied same to Estimator * Added test. Fixed error in skip_transpilation * Release notes * Cleaning code: Changed '_options' to 'self._options' in primitive constructors. * Black --------- Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Accept all options on given on level 1 and assign them to the appropriate hierarchical option type.
Details and comments
For example, if the user defines
options = {"shots": 1024}as input to one of the primitives, we translate it tooptions = {"execution": {"shots": 1024}}.Fixes #755.