Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set error levels to default when no backend is selected #772

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 27, 2023

Summary

As @merav-aharoni mentioned in #748 (comment), if self._session.backend() does not exist, the optimization and resilience levels will be set to None which would fail the job.

This could happen on cloud when no backend is selected, or when the sampler/estimator are used as sessions

tests should be covered in #748

Details and comments

Fixes #

@kt474 kt474 requested review from jyu00 and merav-aharoni March 27, 2023 14:57
@coveralls
Copy link

coveralls commented Mar 27, 2023

Pull Request Test Coverage Report for Build 4536923350

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 66.72%

Totals Coverage Status
Change from base Build 4533420691: 0.03%
Covered Lines: 3318
Relevant Lines: 4973

💛 - Coveralls

Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will test PR #748 after this one is merged.

@kt474 kt474 merged commit e6dde6f into Qiskit:main Mar 27, 2023
@kt474 kt474 deleted the error-lvl-defaults-no-backend branch March 27, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants