Retrieve backends with runtime api #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4559360833
💛 - Coveralls |
kt474
added
the
Changelog: API Change
kt474
commented
Mar 28, 2023
| @@ -342,13 +342,13 @@ def close_session(self, session_id: str) -> None: | |||
|
|
|||
| # IBM Cloud only functions | |||
|
|
|||
| def list_backends(self) -> List[str]: | |||
| def list_backends(self, hgp: Optional[str] = None) -> List[str]: | |||
| """Return IBM Cloud backends available for this service instance. | |||
|
|
|||
| Returns: | |||
| IBM Cloud backends available for this service instance. | |||
There was a problem hiding this comment.
these docstring and comments should be updated since they are not cloud only
jyu00
approved these changes
Mar 29, 2023
frankharkins
pushed a commit
to frankharkins/qiskit-ibm-runtime
that referenced
this pull request
Apr 3, 2023
* wip initial commit * use runtime api * fix unit tests * remove accountclient * add instance param * remove incorrect comments/docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #741 which is a much bigger effort to minimize duplicated code between provider repos.
Since #741 will likely not be ready this week, this PR only makes updates to use the runtime api instead of the iqx api to retrieve backends
Details and comments
Fixes #