This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Handle parameterized circuits #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Qiskit/qiskit#3383 the conversion of types outside the standard set of types understood by the standard json encoder is the responsibility of the ibmq provider. However, there was one type missing from the custom encoder class added to handle this, ParameterExpression. For bound parameterized circuit the ParameterExpression class will be castable to a float to get the bound numeric value that should be sent on the wire with the job. However, the encoder doesn't have handling for this. Qiskit/qiskit#3959 is adding conversion for the to_dict() qobj method so that floats are output, but this a stop gap workaround while a better solution is being developed. We should have handling in qiskit-ibmq-provider if/when ParameterExpression objects get passed in via qobj object.
mtreinish
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After Qiskit/qiskit#3383 the conversion of types outside the
standard set of types understood by the standard json encoder is the
responsibility of the ibmq provider. However, there was one type missing
from the custom encoder class added to handle this, ParameterExpression.
For bound parameterized circuit the ParameterExpression class will be
castable to a float to get the bound numeric value that should be sent
on the wire with the job. However, the encoder doesn't have handling for
this. Qiskit/qiskit#3959 is adding conversion for the to_dict()
qobj method so that floats are output, but this a stop gap workaround
while a better solution is being developed. We should have handling
in qiskit-ibmq-provider if/when ParameterExpression objects get passed
in via qobj object.
Details and comments