This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
RippleAdder benchmarks don't set seed_transpiler
#1404
Labels
enhancement
New feature or request
Comments
|
A few others too by the looks of things: #1405. |
mtreinish
pushed a commit
that referenced
this issue
Jan 25, 2022
Fill in a missing seed for all benchmarks that need one. Fixes #1404
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this issue
Aug 1, 2023
Fill in a missing seed for all benchmarks that need one. Fixes Qiskit/qiskit-metapackage#1404
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this issue
Aug 11, 2023
Fill in a missing seed for all benchmarks that need one. Fixes Qiskit/qiskit-metapackage#1404
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this issue
Sep 7, 2023
Fill in a missing seed for all benchmarks that need one. Fixes Qiskit/qiskit-metapackage#1404
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is the expected behavior?
The benchmarks that live in
test/benchmarks/ripple_adder.pydon't set a value forseed_transpiler, resulting in noisy outputs that can hide small but significant changes. e.g. intrack_depth_transpile_square_grid_ripple_adder, only Qiskit/qiskit#7205 is visible. https://qiskit.github.io/qiskit/#ripple_adder.RippleAdderTranspile.track_depth_transpile_square_grid_ripple_adder?commits=2fe852faThe text was updated successfully, but these errors were encountered: