Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Issue 78 fix meta for latest pip #119

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

delapuente
Copy link
Contributor

@delapuente delapuente commented Feb 19, 2019

Fix #78

Forces the process to finish with an error (which is semantically more accurate) making pip fallback to installing from sources.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested this locally and the qiskit package is installable (albeit with an ugly error displayed by pip) with the latest version of pip, 19.0.2. Without this patch it fails as reported in #78.

I do hope at some point we can remove this workaround to reinstall terra, because it makes debugging install issues much trickier.

@derivation derivation merged commit e27af3e into Qiskit:master Feb 19, 2019
@derivation
Copy link
Contributor

@mtreinish do you think it worth while to add an Issue calling for a more direct solution in your own words?

@mtreinish
Copy link
Member

@derivation I'm not sure there is an alternative, the need for the workaround is caused by the qiskit python package owning the qiskit python namespace before the 0.7, which isn't a condition that will ever change. If we want to make sure there is a seamless upgrade process from anyone using qiskit<0.7 to a newer version we'll probably always need that. My comment before was just my idle thoughts on how I dislike that it's needed at all.

@derivation
Copy link
Contributor

@mtreinish now I understand :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants