Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Update asv.conf.json to support recent changes #1437

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

mtreinish
Copy link
Member

Summary

This commit updates the asv configuration to support two recent changes
in the terra repo. The first is updating the supported python version
list to reflect the current versions supported by terra. Python 3.6 is
no longer supported and python 3.10 is now supported. Additionally,
after Qiskit/qiskit#7658 merged setuptools-rust and Rust are now
being used to build compiled extensions. While cython is still being
used, it's use will be removed soon with Qiskit/qiskit#7702. This
commit updates the build configuration to build the rust extension and
then build a wheel from it instead of building the cython extension.

Details and comments

This commit updates the asv configuration to support two recent changes
in the terra repo. The first is updating the supported python version
list to reflect the current versions supported by terra. Python 3.6 is
no longer supported and python 3.10 is now supported. Additionally,
after Qiskit/qiskit#7658 merged setuptools-rust and Rust are now
being used to build compiled extensions. While cython is still being
used, it's use will be removed soon with Qiskit/qiskit#7702. This
commit updates the build configuration to build the rust extension and
then build a wheel from it instead of building the cython extension.
@jakelishman
Copy link
Member

Semi-unrelated, but is there a path through the build that does what we need, but respects the pyproject.toml build-requires section? Feels like we oughtn't to need to manually specify Cython and setuptools_rust.

@mtreinish
Copy link
Member Author

If we drop the explicit python setup.py build* call we can respect the pyproject.toml and leverage pep 518 to install setuptools rust. For this I mostly was just adapting what we already had which predates our use of a pyproject.toml in terra I can update it if you'd prefer to just modernize the whole thing now

@jakelishman
Copy link
Member

No, I'm happy to do that later - I only commented on it now because I was looking at it.

@jakelishman jakelishman merged commit fc02be9 into Qiskit:master Mar 1, 2022
@mtreinish mtreinish deleted the update-asv branch March 1, 2022 15:32
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
…kage#1437)

This commit updates the asv configuration to support two recent changes
in the terra repo. The first is updating the supported python version
list to reflect the current versions supported by terra. Python 3.6 is
no longer supported and python 3.10 is now supported. Additionally,
after Qiskit#7658 merged setuptools-rust and Rust are now
being used to build compiled extensions. While cython is still being
used, it's use will be removed soon with Qiskit#7702. This
commit updates the build configuration to build the rust extension and
then build a wheel from it instead of building the cython extension.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants