This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
Update building from source instructions #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Qiskit/qiskit#7658 and Qiskit/qiskit#7702 not far behind the requiremetns for building terra from source will be changed. A C++ compiler is no longer required and instead a rust compiler is needed. This commit updates the instructions on building from source and also removes so old out of date notes from the document at the same time.
|
I think we probably should hold off on this until Qiskit/qiskit#7702 merges and we no longer depend on cython and only rust is required. |
garrison
reviewed
Mar 1, 2022
|
Now that Qiskit/qiskit#7702 has merged I think we can move forward on this |
jakelishman
reviewed
Mar 22, 2022
|
|
||
| xcode-select --install | ||
| https://rustup.rs/ |
There was a problem hiding this comment.
This URL just ends up kind of awkwardly in its own paragraph - perhaps it'd be better to hyperlink the words "rustup, which is a cross-platform Rust installer"?
There was a problem hiding this comment.
I was trying to make the link pretty prominent instead of hidden behind a hyperlink since I expect most people reading this section will want to click it. I was worried a hyperlink wouldn't be super clear.
jakelishman
reviewed
Mar 23, 2022
jakelishman
approved these changes
Mar 23, 2022
mtreinish
added a commit
to mtreinish/qiskit
that referenced
this pull request
Oct 31, 2022
In Qiskit#1439 we updated the install from source documentation to reflect recent (as in the last year) changes to the build process and ensure the documentation was correct for installing from source. However, in Qiskit#1507 where some of the documentation was refactored these changes were inadvertadntly delete. This commit restores the correct source installation instructions from Qiskit#1439 so that the hosted docs correctly document how to build and install qiskit from source. Fixes Qiskit#1624
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
* Fix install from source docs In #1439 we updated the install from source documentation to reflect recent (as in the last year) changes to the build process and ensure the documentation was correct for installing from source. However, in #1507 where some of the documentation was refactored these changes were inadvertadntly delete. This commit restores the correct source installation instructions from #1439 so that the hosted docs correctly document how to build and install qiskit from source. Fixes #1624 * Update docs/getting_started.rst * Remove unnecessary pip install from aer instructions
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
) * Update building from source instructions With Qiskit#7658 and Qiskit#7702 not far behind the requiremetns for building terra from source will be changed. A C++ compiler is no longer required and instead a rust compiler is needed. This commit updates the instructions on building from source and also removes so old out of date notes from the document at the same time. * Apply suggestions from code review * Consistently capitalise "Rust" * Add section on modifying rust extension * Fix typos * Empty-Commit to retrigger ci after outage Co-authored-by: Jake Lishman <jake@binhbar.com>
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
* Fix install from source docs In Qiskit/qiskit-metapackage#1439 we updated the install from source documentation to reflect recent (as in the last year) changes to the build process and ensure the documentation was correct for installing from source. However, in Qiskit/qiskit-metapackage#1507 where some of the documentation was refactored these changes were inadvertadntly delete. This commit restores the correct source installation instructions from Qiskit/qiskit-metapackage#1439 so that the hosted docs correctly document how to build and install qiskit from source. Fixes Qiskit/qiskit-metapackage#1624 * Update docs/getting_started.rst * Remove unnecessary pip install from aer instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With Qiskit/qiskit#7658 and Qiskit/qiskit#7702 not far
behind the requiremetns for building terra from source will be changed.
A C++ compiler is no longer required and instead a rust compiler is
needed. This commit updates the instructions on building from source and
also removes some old out of date notes from the document at the same
time.
Details and comments