This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
Random circuit hex less random #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
force-pushed
the
random_circuit_hex_less_random
branch
from
ea725fa to
5455de0
Compare
mtreinish
reviewed
Jun 21, 2019
There was a problem hiding this comment.
LGTM, hopefully this will improve some of the data we get from these benchmarks. One small thing, but I'm thinking a change like this warrants bumping the version of the benchmark (see L77). Since it could arguably produce different results from previous runs. What do you think?
|
I think that makes sense. There's not a lot of signal in the old data, so I don't think much is lost in bumping the version number, and we can always requeue old commits. |
jaygambetta
approved these changes
Jun 22, 2019
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
Attempt to remove some of the randomness in the random_circuit_hex benchmark [1] by seeding the random_unitary generation and the transpiler. [1] https://qiskit.github.io/qiskit/#random_circuit_hex.BenchRandomCircuitHex.track_depth_ibmq_backend_transpile * Remove deprecated function from random_circuit_hex benchmark. * Remove some rmore randomness from random_circuit_hex benchmark. * Bump random_circuit_hex benchmark version.
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
Attempt to remove some of the randomness in the random_circuit_hex benchmark [1] by seeding the random_unitary generation and the transpiler. [1] https://qiskit.github.io/qiskit/#random_circuit_hex.BenchRandomCircuitHex.track_depth_ibmq_backend_transpile * Remove deprecated function from random_circuit_hex benchmark. * Remove some rmore randomness from random_circuit_hex benchmark. * Bump random_circuit_hex benchmark version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to remove some of the randomness in the random_circuit_hex benchmark ( https://qiskit.github.io/qiskit/#random_circuit_hex.BenchRandomCircuitHex.track_depth_ibmq_backend_transpile ) by seeding the random_unitary generation and the transpiler.