Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

random_circuit_hex benchmark backwards compatility #358

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

kdk
Copy link
Member

@kdk kdk commented Jul 2, 2019

Makes two additional changes to random_circuit_hex to better support older qiskit versions.

  1. Re-orders import attempts for euler_angles_1q. At some point in time, trying to call euler_angles_1q via qiskit.mapper would import successfully, but raise when called with an error like qiskit.exceptions.QiskitError: 'euler_angles_1q functionality is now accessible in qiskit.quantum_info.synthesis'. Change default order to always use the newest version of euler_angles_1q that's available.

  2. Falls back to setting seet_mapper for versions of qiskit earlier than seed_transpiler.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, hopefully this will address all the compat issues moving between 0.7..HEAD

@mtreinish mtreinish merged commit d934be5 into Qiskit:master Jul 2, 2019
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 1, 2023
…apackage#358)

Makes two additional changes to random_circuit_hex to better support older
qiskit versions.

Re-orders import attempts for euler_angles_1q. At some point in time, trying to call
euler_angles_1q via qiskit.mapper would import successfully, but raise when called
with an error like qiskit.exceptions.QiskitError: 'euler_angles_1q functionality is now
accessible in qiskit.quantum_info.synthesis'. Change default order to always use the
newest version of euler_angles_1q that's available.

Falls back to setting seed_mapper for versions of qiskit earlier than seed_transpiler.
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
…apackage#358)

Makes two additional changes to random_circuit_hex to better support older
qiskit versions.

Re-orders import attempts for euler_angles_1q. At some point in time, trying to call
euler_angles_1q via qiskit.mapper would import successfully, but raise when called
with an error like qiskit.exceptions.QiskitError: 'euler_angles_1q functionality is now
accessible in qiskit.quantum_info.synthesis'. Change default order to always use the
newest version of euler_angles_1q that's available.

Falls back to setting seed_mapper for versions of qiskit earlier than seed_transpiler.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants