This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
Add timing benchmark for import qiskit.
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
previously approved these changes
Aug 19, 2019
There was a problem hiding this comment.
LGTM, a nice simple benchmark and important to track. Especially because I've added several things that I know make the import slower (like the __qiskit_version__ pip checks). It does make me wish there was a good way to track the import time in an isolated venv (like what asv gives us) vs a full environment with all the elements installed so the namespace is larger.
jaygambetta
approved these changes
Aug 20, 2019
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a first benchmark to measure how long it takes to import top-level qiskit. This will include some overhead in starting up a new python interpreter, but that should be relatively consistent. ( numpy/numpy#8159 has some discussion over their approach, which is the same as is taken here.)