Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set limit to a size of uploaded artifact #340

Closed
IceKhan13 opened this issue Mar 23, 2023 · 5 comments
Closed

Set limit to a size of uploaded artifact #340

IceKhan13 opened this issue Mar 23, 2023 · 5 comments
Labels
enhancement New feature or request priority: medium Medium priority project: gateway Label to identify features related with gateway project project: repository Label to identify features related with repository project
Milestone
0.2

Comments

@IceKhan13
Copy link
Member

IceKhan13 commented Mar 23, 2023 •
edited
Loading

What is the expected enhancement?

Set validation rule of size of uploaded file.

50 mb should be more than enough even if we are packing large modules.
@IceKhan13 IceKhan13 added the enhancement New feature or request label Mar 23, 2023
@IceKhan13 IceKhan13 added this to the 0.2 milestone Mar 23, 2023
@psschwei
Copy link
Collaborator

In addition to setting this on the gateway, you may also need to set it on the ingress for k8s implementations. iirc, the ingress config is done via an annotation, though it's been a while.

@IceKhan13 IceKhan13 added the priority: medium Medium priority label Mar 23, 2023
@IceKhan13
Copy link
Member Author

And, in ideal case, limitation on client side to :)

@akihikokuroda
Copy link
Collaborator

If I remember correctly, the post data size limit is much smaller in ingress by default. It must be increased.

@Tansito Tansito added the project: gateway Label to identify features related with gateway project label Mar 23, 2023
@Tansito Tansito changed the title Gateway: set limit to a size of uploaded artifact Set limit to a size of uploaded artifact Mar 23, 2023
@Tansito Tansito added the project: repository Label to identify features related with repository project label Mar 23, 2023
@Tansito
Copy link
Member

Tansito commented Mar 23, 2023

I assume this should be done in repository and in gateway.

@psschwei
Copy link
Collaborator

psschwei commented Aug 2, 2023

I think #818 was a duplicate of this one. We fixed it in #826 , so should be good to close this one.

@psschwei psschwei closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority: medium Medium priority project: gateway Label to identify features related with gateway project project: repository Label to identify features related with repository project
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
4 participants
@IceKhan13 @Tansito @akihikokuroda @psschwei