-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase NGINX body-size #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I got a little confused with the changes in the value.yaml file change for the local install. There are 2 ingress instances configurations in the value file. One is installed with Ray operator and the other is installed as a dependency of the quantum-serferless chart. The changes make the change in the ingress installed with Ray operator that is not enable for the local install. The other ingress is enabled for the local install. |
Mmm... Which instance for Ray operator do you mean, @akihikokuroda ? Right now I see two different instances:
I admit that there we can have a bit of confuse because depending on the provider we are going to need to change that configuration. I'm totally open to improve that (I think @psschwei mentioned before some ways to fix it). |
The other ingress being the quantum-serverless dependency, right? FWIW, I've never used ingress with a local install, always just done port-forwarding of the gateway (and the notebook, if I'm running that via k8s). |
@psschwei Yes, it is. |
Ahh, I missed your last comment (need to remember to refresh the page if I leave it open too long before commenting 😄 ) |
I see your point and I was not aware about that cc to @IceKhan13 too here 👀 |
Summary
Fix #818
Co-authored-by: @psschwei
Confirmed with the infrastructure team and added the required label specified in the issue:
proxy-body-size
.