Client + docs: rename Program
#1057
Conversation
IceKhan13
force-pushed
the
chore/rename-program-to-pattern
branch
from
f545d87 to
fc28254
Compare
IceKhan13
force-pushed
the
chore/rename-program-to-pattern
branch
from
fc28254 to
4011d6a
Compare
| "job" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 7, | ||
| "execution_count": null, |
There was a problem hiding this comment.
do you want to execute this cell? (think there might also one other in this notebook that wasn't executed...)
There was a problem hiding this comment.
I left a couple of comments and I found a couple of references in the documentation that maybe we can review but I would merge it and do next week another pass, what do you think, @IceKhan13 ?
|
|
||
| # create program | ||
| program = Program( | ||
| program = QiskitPattern( |
There was a problem hiding this comment.
Should we rename variable program to pattern too?
pattern = QiskitPattern(
| @@ -166,11 +168,13 @@ def run(self, program: Program, arguments: Optional[Dict[str, Any]] = None): | |||
| ) | |||
| return Job(job_id=job_id, job_client=self) | |||
|
|
|||
| def upload(self, program: Program): | |||
| def upload(self, program: QiskitPattern): | |||
There was a problem hiding this comment.
This can a breaking change so it's a bit tricky but should we call it pattern?
There was a problem hiding this comment.
can you overload functions in python? (i.e. have one that takes a program and mark it deprecated and another that takes a pattern)
There was a problem hiding this comment.
seems like answer is no (though there are a few workarounds if you search around on the topic...)
This is more of a docs change + name alias. It does not change any functionality |
|
We will follow with updates in next PR :) |
Summary
Client + docs: rename
Program