Issue 1131 | Drop keycloak

[IceKhan13]

Summary

Drop keycloak

Details and comments

Closes #1131

[psschwei]

Before merging, I'd like to test this against local Kubernetes too... (I'll run on kind once the PR is out of draft)

[Tansito]

I had almost the same so I'm fine with this PR, @IceKhan13 . What I would do is simplify it a bit, let keycloak stuff and remove everything in another PR, what do you think?

[Tansito]

We have tons of configurations related with keycloak that it will be better review in apart from this I think.

[IceKhan13]

We have tons of configurations related with keycloak that it will be better review in apart from this I think.

Do you mean configurations in helm charts?

What I would do is simplify it a bit

most of the changes in just notebooks diffs :)
if you look at code lines it will be like 50 lines of change, which is simple, I would say 😄

I do not mind if you close this PR and push your changes, I was just sitting in a meeting and decided to take this one.

[Tansito]

Do you mean configurations in helm charts?

Mostly yeah, but around applications too. Something that we can clean in the next PR.

most of the changes in just notebooks diffs :)
if you look at code lines it will be like 50 lines of change, which is simple, I would say 😄

I do not mind if you close this PR and push your changes, I was just sitting in a meeting and decided to take this one.

Yeah, no it's fine. Just to mention in case you were thinking to include to remove all the configuration stuff. That maybe we can let it for another PR.

[Tansito]

Should we remove this from client too, @IceKhan13 ?:

https://github.com/Qiskit-Extensions/quantum-serverless/blob/main/client/quantum_serverless/core/provider.py#L455

[IceKhan13]

Oh, let me remove from client to. YOu are right.

[psschwei]

Got an error when running on Kind:

QuantumServerlessException: Cannot verify token.

(did a pip install . on client, so should be using the most recent updates...)

edit: error was when running this block:

serverless = ServerlessProvider(
    token=os.environ.get("GATEWAY_TOKEN", "awesome_token"),
    host=os.environ.get("GATEWAY_HOST", "http://localhost:8010"),
)
serverless

[Tansito]

Got an error when running on Kind:

QuantumServerlessException: Cannot verify token.

Did you change the authentication mechanism @psschwei ? Now auth mechanism must be mock_token for when you want to test something.

[psschwei]

Did you change the authentication mechanism

No, wasn't expecting that I'd need to (I assumed it would work out of the box)... let me try again

[psschwei]

hmmm... still fails with

 {
    "name": "SETTINGS_AUTH_MECHANISM",
    "value": "mock_token"
  },

[IceKhan13]

@psschwei did you rebuild gateway image?

[psschwei]

@psschwei did you rebuild gateway image?

yes, built from source

[psschwei]

envvar is being picked up inside the gateway pod...

I have no name!@gateway-7b444889b6-dkjh8:/usr/src/app$ python
Python 3.9.16 (main, May 23 2023, 14:24:31) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.environ.get("SETTINGS_AUTH_MECHANISM")
'mock_token'
>>> 

[IceKhan13]

🤔

[psschwei]

looks like the keycloak pod is still there... let me try deleting that (or maybe I should wait for the helm config update in the next PR...)

[IceKhan13]

keycloak chart should not affect it by any means

[psschwei]

does the postgres username matter? looks like I was using bn_keycloak, but not sure if that user is gone now...

[IceKhan13]

nope, it does not matter

[Tansito]

Helm should continue being the same with the difference in the auth.mechanism value I think 🤔

[psschwei]

Ok, I figured out the error... for reference, this was the code block:

serverless = ServerlessProvider(
    token=os.environ.get("GATEWAY_TOKEN", "awesome_token"),
    host=os.environ.get("GATEWAY_HOST", "http://localhost:8010"),
)
serverless

Can anyone spot the problem? 😄

[Tansito]

Damn port?

[psschwei]

Damn port?

You win 😆

[IceKhan13]

ref: #1133

[IceKhan13]

Tested it with rancher locally too. Got the same error like Paul :) ref above

[psschwei]

Worked for me on Kubernetes, code changes look good

[Tansito]

It looks for me good too. Tomorrow I can upload helm configuration.

[IceKhan13]

Tomorrow I can upload helm configuration.

Perfect!