Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop notebook builds #1151

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Drop notebook builds #1151

merged 1 commit into from
Jan 4, 2024

Conversation

psschwei
Copy link
Collaborator

@psschwei psschwei commented Jan 4, 2024

Summary

Fixes #1046
Drop notebook builds

Details and comments

@psschwei
Copy link
Collaborator Author

psschwei commented Jan 4, 2024

lint: commands[1]> pylint -rn quantum_serverless tests
************* Module quantum_serverless.core.decorators
quantum_serverless/core/decorators.py:85:11: E1123: Unexpected keyword argument 'object_refs' in function call (unexpected-keyword-arg)

That's an odd failure for a PR that doesn't touch the code...

@IceKhan13
Copy link
Member

looks like ray has changed wait function signature

@IceKhan13
Copy link
Member

IceKhan13 commented Jan 4, 2024

@IceKhan13
Copy link
Member

@IceKhan13
Copy link
Member

IceKhan13 commented Jan 4, 2024

Fix is in main. Merge main and you should be good to go

https://github.com/Qiskit-Extensions/quantum-serverless/pull/1152/files

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei psschwei force-pushed the drop-notebook-builds branch from dc4d312 to 487d295 Compare January 4, 2024 20:08
@psschwei psschwei merged commit 4ad5659 into Qiskit:main Jan 4, 2024
20 checks passed
@psschwei psschwei deleted the drop-notebook-builds branch January 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants