Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: provide a way to expose services through ingress-controller #126

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jan 20, 2023

Summary

The main objective of this PR is to offer to the user an ingress-controller configuration in case it needs one to expose services. This is interesting for when you don't have an ingress-controller available in localhost when you develop, for example.

Details and comments

  • The ingress-controller is disabled by default to not affect cloud providers' controller default configuration.
  • Fix value.yaml files in terraform with the last configurations.

Related with #125

@Tansito Tansito requested a review from IceKhan13 January 20, 2023 17:15
Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@Tansito Tansito merged commit 0f69367 into main Jan 20, 2023
@Tansito Tansito deleted the helm-improvement branch January 20, 2023 17:28
akihikokuroda pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants