-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple groups in a provider #1416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would you add example of the structure of user, groups and provider? I assume there are user for consumer, provider and admin and groups for function admins and function user for each function.
What do you have in mind, @akihikokuroda ? Some kind of diagram? I can prepare it monday an update it to the PR |
Yeah, a diagram is great.thanks |
Something like this would be what are you looking for, @akihikokuroda ? |
@Tansito It's a little different. What I want is probably an instance diagram that has some example user, provider and groups. |
I'm going to wait for #1406 before merge this. I think it's easier to migrate the logic from this PR to |
# Conflicts: # gateway/api/authentication.py
Initially is ready for review but Monday I will give it a last review just in case I missed any reference. |
Summary
This PR enables to have more than one group managing the resources of a provider. The idea is that more than one group could update a function if it would be needed.
This is needed due to that right now how we don't have a fully working workflow to enable that a provider publish a function so we need to give permissions to ourselves too to do it.
Details and comments
To accomplish this use case we basically did the next steps:
admin_group
field from Provideradmin_groups
field to the Provider as a M2M relationship