Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple groups in a provider #1416

Merged
merged 14 commits into from
Jul 31, 2024
Merged

Multiple groups in a provider #1416

merged 14 commits into from
Jul 31, 2024

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jul 18, 2024

Summary

This PR enables to have more than one group managing the resources of a provider. The idea is that more than one group could update a function if it would be needed.

This is needed due to that right now how we don't have a fully working workflow to enable that a provider publish a function so we need to give permissions to ourselves too to do it.

Details and comments

To accomplish this use case we basically did the next steps:

  • Removed admin_group field from Provider
  • Added admin_groups field to the Provider as a M2M relationship
  • Changed the current logic to support the change

@Tansito Tansito marked this pull request as ready for review July 19, 2024 18:46
Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you add example of the structure of user, groups and provider? I assume there are user for consumer, provider and admin and groups for function admins and function user for each function.

@Tansito
Copy link
Member Author

Tansito commented Jul 19, 2024

What do you have in mind, @akihikokuroda ? Some kind of diagram? I can prepare it monday an update it to the PR

@akihikokuroda
Copy link
Collaborator

Yeah, a diagram is great.thanks

@Tansito
Copy link
Member Author

Tansito commented Jul 22, 2024

Screenshot 2024-07-22 at 10 18 27 AM

Something like this would be what are you looking for, @akihikokuroda ?

@akihikokuroda
Copy link
Collaborator

@Tansito It's a little different. What I want is probably an instance diagram that has some example user, provider and groups.

@Tansito
Copy link
Member Author

Tansito commented Jul 22, 2024

I'm going to wait for #1406 before merge this. I think it's easier to migrate the logic from this PR to admin_groups than for the other one.

@Tansito Tansito marked this pull request as draft July 22, 2024 21:45
@Tansito Tansito requested a review from akihikokuroda July 26, 2024 21:14
@Tansito Tansito marked this pull request as ready for review July 26, 2024 21:14
@Tansito
Copy link
Member Author

Tansito commented Jul 26, 2024

Initially is ready for review but Monday I will give it a last review just in case I missed any reference.

@Tansito Tansito merged commit cedb70a into main Jul 31, 2024
10 checks passed
@Tansito Tansito deleted the admin-groups-migration branch July 31, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants