-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build ray image with ubi base #1418
Conversation
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Where are the code for the ray head and ray worker nodes installed? |
The Ray libraries are installed as part of the client install. I'll make that clearer by adding an explicit call to install the requirements.txt file. |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
The same UBI base image has been used for the gateway. It's been working on my mac. |
@akihikokuroda when you have a chance (not urgent), can you build this image and run the test suite? would be good to verify it works on arm 🙏 |
I got this build error.
|
I'm not sure why it works for the gateway but not for the ray-node. |
looks like arm updated to el9_4.3 ? (full package list: here's the package list for aarch64: https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi9/9/aarch64/appstream/os/Packages/p/) |
@akihikokuroda do we need to specify the version numbers for the packages we're installing? or could we get by with something like |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei Yes, it builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Static scan probably ask us to add the version :-)
|
ok, if we have to add the version then we'll need to separate out the x86 and aarch64 builds, as there are different package versions for each architecture. do you have a link to an example of the static scan requiring the version to be hard-coded? |
It is (was?) the docker file linter that runs in Travis CI. This one fixed the package installed by the apt. af8d62a |
I don't know the static scan specifically but security is helping us to pass all the scans for the providers without a version on it. So maybe not needed right now to try to fix the vulnerabilities that we find. I would merge this, push the image in our registry and ask them to scan it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could build it and run it too!
Apart from my previous comment I see everything fine 🎉
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
I had to drop the versions from the gateway image too, but we can just send both images to security
|
Summary
Build the ray image using a UBI base
Details and comments
This currently only tests x86, as I have no way to test an ARM image. Per Aki, the UBI base images work on Apple Silicon.
I've also left the old dockerfile (using the community Ray image as a base), in case that's helpful.
This also pins numpy to v1.x, as v2 causes a number of issues