Implement allowlist framework for dependencies #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to add tests for the new functionality... |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Allow operators to specify an allowlist of dependencies and allowed
versions.
The allowlist is stored in a config file.
A sample allowlist might look like:
allowlist = { "wheel": ["0.44.0", "0.43.2"] }
which would imply that the wheel package is allowed, but only versions
0.43.2 and 0.44.0 .
For this PR, the allowlist is empty, which means all dependencies are
allowed, and it is stored locally. In a future PR, this should move
into a Kubernetes configmap so that it can be updated without having
to rebuild the container.
Each dependency can optionally specify a list of allowed versions. If
the list is empty, then all versions of the dependency are allowed.
An example:
allowlist = { "wheel": [] }
This could also be adapted to store a minimum allowed version instead
of listing all allowed versions, depending on requirements.
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
psschwei
force-pushed
the
limit-dependencies
branch
from
967f06e to
3d93127
Compare
|
ok, this should be ready for review now |
Tansito
reviewed
Aug 8, 2024
Tansito
reviewed
Aug 9, 2024
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Tansito
reviewed
Aug 9, 2024
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
|
xref #369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul S. Schweigert paul@paulschweigert.com
Allow operators to specify an allowlist of dependencies and allowed versions.
The allowlist is stored in a config file.
A sample allowlist might look like:
which would imply that the wheel package is allowed, but only versions 0.43.2 and 0.44.0 .
For this PR, the allowlist is empty, which means all dependencies are allowed, and it is stored locally. In a future PR, this should move into a Kubernetes configmap so that it can be updated without having to rebuild the container.
Each dependency can optionally specify a list of allowed versions. If the list is empty, then all versions of the dependency are allowed.
An example:
This could also be adapted to store a minimum allowed version instead of listing all allowed versions, depending on requirements.