Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None description shouldnt be updated #1508

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

korgan00
Copy link
Collaborator

@korgan00 korgan00 commented Oct 7, 2024

Summary

Details and comments

@korgan00 korgan00 requested a review from Tansito October 7, 2024 17:42
@Tansito
Copy link
Member

Tansito commented Oct 7, 2024

I think you need to run tox -eblack to fix the formatting, @korgan00

Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one nit comment. Other than that, LGTM!

Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @akihikokuroda comment, apart from that LGTM too 👍

@korgan00 korgan00 merged commit a8c4489 into main Oct 9, 2024
10 checks passed
@Tansito Tansito deleted the prevent-null-description-update branch October 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants