Catalog returns only the functions that you can run #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
commented
Nov 22, 2024
| @@ -49,7 +49,7 @@ | |||
| "password": "pbkdf2_sha256$390000$kcex1rxhZg6VVJYkx71cBX$e4ns0xDykbO6Dz6j4nZ4uNusqkB9GVpojyegPv5/9KM=", | |||
| "is_active": true, | |||
| "groups": [ | |||
| 101 | |||
| 100 | |||
There was a problem hiding this comment.
This is to change the user group to the runner one that has the run permission.
Tansito
commented
Nov 22, 2024
gateway/api/views/programs.py
Outdated
| author = self.request.user | ||
| type_filter = self.request.query_params.get("filter") | ||
|
|
||
| if type_filter == "serverless": |
There was a problem hiding this comment.
@korgan00 let's comment about these values, Monday. I think we can use the Enum approach that we used in the last PR but how they don't accept strings if we don't use StrEnum we will need to compare them in a different way probably.
korgan00
pushed a commit
that referenced
this pull request
Dec 9, 2024
* move program model access to repository * remove unused code * fix linter * fixed tests * update swagger information * added logger in the repository class * rename provider method * added TypeFilter enum * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is PR continues the work done in #1526
The end-point that returns the list of the Functions for the Catalog is returning all the those Functions with
viewpermission. This was generating some frustrations becauseviewpermission doesn't give you access to run them. So with this PR now we will return only those functions for what the user hasrunpermission.This PR also introduces a refactor around how
GETend-points fromProgramview were managing the access to the model. With the purpose to continue adding good practices to the base code we are starting to introduce some new concepts:Repositoryclass. In this case we started with thegetmethods for theProgramview. We will continue the refactor in future PR.listend-point doesn't filter by title. We are doing that using the end-pointget_by_title.