Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localclient to integration tests #1549

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Conversation

korgan00
Copy link
Collaborator

Summary

Details and comments

@korgan00 korgan00 marked this pull request as draft December 10, 2024 17:54
@korgan00 korgan00 marked this pull request as ready for review December 11, 2024 18:09
@korgan00 korgan00 requested review from paaragon and Tansito December 11, 2024 18:20
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I see everything fine, @korgan00 . Just a couple of comments that are not required to be honest. Thank you so much for this PR 🙏

client/qiskit_serverless/core/clients/local_client.py Outdated Show resolved Hide resolved
tests/docker/conftest.py Outdated Show resolved Hide resolved
@Tansito Tansito self-requested a review December 13, 2024 19:05
@Tansito
Copy link
Member

Tansito commented Dec 13, 2024

I'm not sure if I could merge this, @korgan00 so I leave my approval and feel free to merge it if you finished all the last changes 🙏

@korgan00 korgan00 merged commit 08168b6 into main Dec 13, 2024
9 checks passed
@Tansito Tansito deleted the tests/add-integration-local branch December 13, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants