Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 217 | Docs: getting started 3 level tutorials #222

Merged
merged 19 commits into from
Mar 21, 2023

Conversation

IceKhan13
Copy link
Member

Summary

Docs: getting started 3 level tutorials

Details and comments

Closes #217

@IceKhan13 IceKhan13 added the documentation Improvements or additions to documentation label Feb 20, 2023
@IceKhan13 IceKhan13 added this to the 0.1 milestone Feb 20, 2023
@IceKhan13 IceKhan13 changed the base branch from main to issue-254/gateway March 20, 2023 13:02
Base automatically changed from issue-254/gateway to main March 21, 2023 18:39
Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran into a docker-compose issue, so didn't get too far yet, but here's a few comments on the very beginning

README.md Outdated
<details>
<summary>1. Hello World quickstart</summary>

1 - Create program file `hello_qiskit.py`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth it to have a samples/ directory with these code snippets in it? so folks don't have to c&p...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting started is now referring to docker compose jupyter instance which has everything needed (all files and examples)

README.md Outdated
2 - Run program file
```python
from quantum_serverless import QuantumServerless, Program
serverless = QuantumServerless(...) # serverless setup is provided by your admin or use docker compose (refer to all-in-one quickstart)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the all-in-one is step 2, so I'd add the docker-compose setup before this (so that users don't have to stop and go back to setup their environment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified it to bare minimum. Jen will conduct user research to figure out what is the best way to describe getting started.

docs/Untitled.ipynb Outdated Show resolved Hide resolved
@IceKhan13 IceKhan13 marked this pull request as ready for review March 21, 2023 22:59
Copy link
Collaborator

@jenglick jenglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thank you!

@IceKhan13 IceKhan13 merged commit e85392d into main Mar 21, 2023
@IceKhan13 IceKhan13 deleted the issue-217/readme-examples branch March 21, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve readme and docs
3 participants