-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 217 | Docs: getting started 3 level tutorials #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran into a docker-compose issue, so didn't get too far yet, but here's a few comments on the very beginning
README.md
Outdated
<details> | ||
<summary>1. Hello World quickstart</summary> | ||
|
||
1 - Create program file `hello_qiskit.py` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth it to have a samples/
directory with these code snippets in it? so folks don't have to c&p...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting started is now referring to docker compose jupyter instance which has everything needed (all files and examples)
README.md
Outdated
2 - Run program file | ||
```python | ||
from quantum_serverless import QuantumServerless, Program | ||
serverless = QuantumServerless(...) # serverless setup is provided by your admin or use docker compose (refer to all-in-one quickstart) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the all-in-one is step 2, so I'd add the docker-compose setup before this (so that users don't have to stop and go back to setup their environment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified it to bare minimum. Jen will conduct user research to figure out what is the best way to describe getting started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- thank you!
Summary
Docs: getting started 3 level tutorials
Details and comments
Closes #217