-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication to apiserver #235
Conversation
10832f6
to
a528d6f
Compare
fbf35b7
to
49e92fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @akihikokuroda
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
49e92fb
to
5c9e265
Compare
@@ -59,6 +67,12 @@ Install from specific values file | |||
kubectl patch svc -n ray kuberay-apiserver-service --type json --patch '[{"op" : "replace" ,"path" : "/spec/selector" ,"value" : {"app.kubernetes.io/component": "kuberay-apiserver"}}]' | |||
``` | |||
|
|||
(temporary) Patch the kuberay-apiserver deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I couldn't have time to review this pull request properly 🙏
My only question for the future would be how we can remove this patch? I assume that is something related with ray like the patch that we have above, doesn't it, @psschwei , @akihikokuroda ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. The fix(es) has already been merged upstream, so once there's a new release cut we can bump our deps and drop the patch(es)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question was more related to what actions do we need to apply to remove the patch (or not need it)? Like for example with the first one, that we need to open an issue in ray to fix the app.kubernetes.io/component
annotation. I assume that the problem in this case is that we can't add as sidecar in the kuberay-api
the gatekeeper
image? To have it under control and move these things as soon as I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sidecar patch, the sidecar setting is already in the values.yaml so when kuberay has a new release and we upgrade, we can just remove the patch script and update the README. For the service, we can just update the README when we get the new kuberay release.
Summary
PR: #189 is a pre-req for this.
Fix #138
This PR enables "Client Credentials Grant" in OAuth2 specification for the apiserver.
Details and comments
Access to the apiserver needs the access token issued by the keycloak.
Here is the example script accessing the apiserver.