-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API gateway versioning #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: in one place we use if version is None
whereas in the other we use version = version or os.environ...
do we want to standardize?
Forget it, you are right in fact there was a bug in the logic 😂 |
Now it should work as expected @psschwei . If a user specifies a version overrides everything, if not it goes the environment and at the end the default value. I can't add the |
# Conflicts: # gateway/main/urls.py
From what I tested there is no breaking changes in the documentation plus all the changes were internal so merging it right now! |
Summary
This PR includes support in
gateway
api for different versions and introduce the change in theclient
.Details and comments
ViewSets
to support different versions now has dynamic serializers withget_serializer_class
ray_job_status_to_model_job_status
User
model inside job to remove the pylint error, now we access the user throughget_user_model
run_program
end-point to be justrun
requests
package is added to requirementsFix #308