notebook container build for m1 mac #427
Conversation
There was a problem hiding this comment.
Don't have a mac (m1 or otherwise) so can't say if this fixes the issue, but this build fine on x86
One question: do we need all of build-essentials? If so, how much bigger does it make the image? (I doubt it's much, but worth a look in case it causes it to jump a bunch)
When checking the build, noticed that the Makefile still uses the old version... if you're fixing build stuff, may as well go ahead and bump that to 0.0.6 🙏
|
@psschwei Thanks for review. The install size of the build-essential is about 20k. It's not too bad, I think. I'll update the version. |
akihikokuroda
force-pushed
the
m1-notebook
branch
from
a138a7a to
870d0e5
Compare
bump up version 0.0.6 Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
akihikokuroda
force-pushed
the
m1-notebook
branch
from
870d0e5 to
0357e12
Compare
| @@ -1,6 +1,9 @@ | |||
| ARG IMAGE_PY_VERSION=3.9 | |||
| FROM jupyter/base-notebook:python-$IMAGE_PY_VERSION | |||
|
|
|||
| USER 0 | |||
| RUN apt-get -y update && apt-get -y install gcc build-essential libopenblas-dev | |||
There was a problem hiding this comment.
@akihikokuroda could you take a look if the repository application will require this kind of approach too? Apart from that as @psschwei said it built correctly on my side (x86) 😄
There was a problem hiding this comment.
@Tansito Thanks for review. The repository doesn’t need to build wheel for qiskit-aer so it seems Ok.
Summary
Fix #426
Details and comments
Add missing package for build.