Issue 411 | Client: rename run_qiskit_remote to distribute_task
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Thank you @IceKhan13 ! 💯
Btw I didn't do any deprecation with #390 . Should have I done it? Which is our process with these cases?
FWIW, I like the alpha / beta / GA lifcycle we have in Knative (which is itself adapted from the k8s lifecycle): https://knative.dev/docs/serving/configuration/feature-flags/#lifecycle (if we follow that lifecycle, I'd figure we're still in alpha at this point, which would mean no need to deprecate and could just include that it's a breaking change in the release notes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Client: rename
run_qiskit_remotetodistribute_taskrun_qiskit_remoteis deprecated until 0.2 releaseDetails and comments
Closes #411