Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM Cloud deployment improvements #447

Merged
merged 36 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
3f0148c
Terraform improvements
Tansito Apr 14, 2023
6c55b12
Helm improvements
Tansito Apr 14, 2023
f301936
Public service endpoint enable
Tansito Apr 17, 2023
f1afb6c
Fix template error in repository
Tansito Apr 17, 2023
aa93d40
Improved deployment configuration
Tansito Apr 17, 2023
617b362
Updated values for the new architecture
Tansito Apr 18, 2023
2201429
Updated kuberay/operator version
Tansito Apr 19, 2023
e61f806
Updated ray-cluster ports configuration with GCS
Tansito Apr 19, 2023
eba6abc
Merge branch 'main' into ibm-cloud-effort
Tansito Apr 20, 2023
9133214
Use nightly for repository
Tansito Apr 20, 2023
ba8e6cf
Fix gateway keycloak's port configuration
Tansito Apr 21, 2023
1d2979f
Merge branch 'main' into ibm-cloud-effort
Tansito Apr 28, 2023
ed509b1
Simplified default values for kuberay-operator
Tansito May 3, 2023
69a7528
Added configurations for additional workers instead of a default worker
Tansito May 3, 2023
96c33e3
Keycloak realm configuration
Tansito May 3, 2023
034acb6
Simplified kuberay-api-server without default values
Tansito May 3, 2023
4ab10b3
Uploaded keycloakRealm
Tansito May 5, 2023
e784798
Fixed DEBUG configuration in repository
Tansito May 5, 2023
e70784f
Fixed keycloak realm users configuration
Tansito May 8, 2023
34773bc
Use ARGS instead of COMMAND
Tansito May 8, 2023
4b713f9
Updated values
Tansito May 8, 2023
1ccd1b6
Remove conditional in ingress
Tansito May 8, 2023
116c0fc
Use dynamic port values in the deployment args
Tansito May 8, 2023
c26aae1
Added swagger to gateway
Tansito May 8, 2023
5a3200f
Merge branch 'main' into ibm-cloud-effort
Tansito May 8, 2023
706cbdf
Removed RELEASE_NAME
Tansito May 8, 2023
394dbe1
Removed RELEASE_NAME from values
Tansito May 8, 2023
3c14397
Use 0.0.7 instead of nightly
Tansito May 8, 2023
28584ba
Revert "Added swagger to gateway"
Tansito May 8, 2023
f023b15
Merge branch 'main' into ibm-cloud-effort
Tansito May 9, 2023
b34340c
Updated main infrastructure README
Tansito May 9, 2023
aeab4db
Updated dockerfile README
Tansito May 9, 2023
9c4b0b9
Updated helm infrastructure
Tansito May 9, 2023
a7faa0b
Updated terraform IBM documentation
Tansito May 9, 2023
626ba6c
Uploaded documentation for IBM Cloud
Tansito May 9, 2023
5d2cf80
Merge branch 'main' into ibm-cloud-effort
Tansito May 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,19 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command: ["python", "manage.py", "runserver", "0.0.0.0:8000"] #[ "gunicorn", "gateway.wsgi:application", "--bind", "0.0.0.0:8000", "--workers=3" ]
command: [ "gunicorn", "main.wsgi:application", "--bind", "0.0.0.0:8000", "--workers=4" ]
Tansito marked this conversation as resolved.
Show resolved Hide resolved
ports:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
livenessProbe:
httpGet:
path: /
port: http
readinessProbe:
httpGet:
path: /
port: http
# livenessProbe:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is this. Maybe we should uncomment this? :)
or /metrics is not available? or do /api/v1/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right. My two cents here from previous experiences is that the security team will ask us for two different end-points for liveness and readiness for a simple HTTP 200 and a DB access. For the DB access I think /api/v1 can work (I would need to confirm it) but for the HTTP 200 we will need a specific end-point. That's why I commented them. If you are agree @IceKhan13 I can create an issue for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :) Yeah, let's add something like /health or something like this in following PRs

# httpGet:
# path: /
# port: http
# readinessProbe:
# httpGet:
# path: /
# port: http
resources:
{{- toYaml .Values.resources | nindent 12 }}
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command: [ "gunicorn", "main.wsgi:application", "--bind", "0.0.0.0:8060", "--workers=4" ]
Tansito marked this conversation as resolved.
Show resolved Hide resolved
ports:
- name: http
containerPort: {{ .Values.service.port }}
Expand All @@ -47,6 +48,15 @@ spec:
# port: http
resources:
{{- toYaml .Values.resources | nindent 12 }}
env:
- name: DEBUG
value: {{ .Values.application.debug | quote }}
- name: DJANGO_SUPERUSER_USERNAME
value: {{ .Values.application.superuser.username | quote }}
- name: DJANGO_SUPERUSER_PASSWORD
value: {{ .Values.application.superuser.password | quote }}
- name: DJANGO_SUPERUSER_EMAIL
value: {{ .Values.application.superuser.email | quote }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
49 changes: 49 additions & 0 deletions infrastructure/helm/quantumserverless/templates/ingress.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{{- if .Values.keycloakEnable }}
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1
{{- else if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
name: ray-ingress
{{- with .Values.ingress.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
{{- if .Values.ingress.tls }}
tls:
{{- range .Values.ingress.tls }}
- hosts:
{{- range .hosts }}
- {{ . | quote }}
{{- end }}
secretName: {{ .secretName }}
{{- end }}
{{- end }}
rules:
{{- range .Values.ingress.hosts }}
- host: {{ .host | quote }}
http:
paths:
{{- range .paths }}
- path: {{ .path }}
{{- if and .pathType (semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion) }}
pathType: {{ .pathType }}
{{- end }}
backend:
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
service:
name: {{ .serviceName }}
port:
number: {{ .servicePort }}
{{- else }}
serviceName: {{ .serviceName }}
servicePort: {{ .servicePort }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}

This file was deleted.

20 changes: 0 additions & 20 deletions infrastructure/helm/quantumserverless/templates/rayingress.yaml

This file was deleted.

Loading