Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM Cloud deployment improvements #447
IBM Cloud deployment improvements #447
Changes from 6 commits
3f0148c
6c55b12
f301936
f1afb6c
aa93d40
617b362
2201429
e61f806
eba6abc
9133214
ba8e6cf
1d2979f
ed509b1
69a7528
96c33e3
034acb6
4ab10b3
e784798
e70784f
34773bc
4b713f9
1ccd1b6
116c0fc
c26aae1
5a3200f
706cbdf
394dbe1
3c14397
28584ba
f023b15
b34340c
aeab4db
9c4b0b9
a7faa0b
626ba6c
5d2cf80
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is this. Maybe we should uncomment this? :)
or
/metrics
is not available? or do/api/v1/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are totally right. My two cents here from previous experiences is that the security team will ask us for two different end-points for
liveness
andreadiness
for a simple HTTP 200 and a DB access. For the DB access I think/api/v1
can work (I would need to confirm it) but for the HTTP 200 we will need a specific end-point. That's why I commented them. If you are agree @IceKhan13 I can create an issue for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense :) Yeah, let's add something like
/health
or something like this in following PRsThis file was deleted.
This file was deleted.