Issue 506 | Gateway: fix permissions for save results #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacomf
approved these changes
May 8, 2023
Tansito
reviewed
May 9, 2023
| @@ -584,5 +584,5 @@ def _fetch_token(self, username: str, password: str): | |||
| if not gateway_response.ok: | |||
| raise QuantumServerlessException(gateway_response.text) | |||
|
|
|||
| gateway_token = json.loads(gateway_response.text).get("access_token") | |||
| gateway_token = json.loads(gateway_response.text).get("access") | |||
There was a problem hiding this comment.
Oh, when did the access_token keyword change to access?
There was a problem hiding this comment.
One of the dependencies released a new major version which got pulled in for the latest builds. @IceKhan13 suggested we may want to pin the deps in #509 , +1 for me.
There was a problem hiding this comment.
Basically this comment #509 (comment)
There was a problem hiding this comment.
Yes! I couldn't answer before due to the problems in GitHub haha. I skipped that comment, thank you team 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gateway: fix permissions for save results + update on JWT access fields
Details and comments
Closes #506