Build and push images to ibm container registry #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
|
Would you enable multi-architecture build if you don't mind? Simple enabling should work all images except the ray-node. |
I'll do that in a follow-up PR... I'd like to ensure the ICR piece works first before adding new functionality (as it'll be easier to troubleshoot if something goes wrong) |
|
would help to add the actual action... 🤦 |
This was referenced May 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
xref: #298
Add actions to build and push images to IBM Container Registry
Details and comments
Adds new workflow / actions for IBM Container Registry (as we'll be retiring DockerHub in the near future, I just duplicated the files rather than adding a registry parameter to the existing one as we can remove the Docker ones once we're happy with the ICR images).
For the image tag, we're going from
qiskittoicr.io/quantum-publicFor the authentication to IBM Cloud, I used https://github.com/IBM/actions-ibmcloud-cli action, which adds the IBM Cloud CLI and logs in to IBM Cloud / Container Registry.