Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: guide on serverless configuration #63

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

IceKhan13
Copy link
Member

Summary

Small guide on serverless configuration

@IceKhan13 IceKhan13 added the documentation Improvements or additions to documentation label Nov 14, 2022
@IceKhan13 IceKhan13 requested review from Tansito and removed request for Tansito November 14, 2022 19:24
@IceKhan13 IceKhan13 requested a review from Tansito November 14, 2022 19:34
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @IceKhan13 💯

"```python\n",
"serverless = QuantumServerless({\n",
"\t\"providers\": [{\n",
"\t\t\"name\": \"my_provider\", # name of provider\n",
Copy link
Member

@Tansito Tansito Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but how do you see to specify a bit more what kind of providers we support? Like:

"\t\t\"name\": \"my_provider\",  # name of provider, currently supporting: ibm, aws\n",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to have separate tutorial/docs on setting up multicloud deployment, where we can showcase that. For this one I wanted to do something generic.

@IceKhan13 IceKhan13 merged commit c822ca4 into main Nov 16, 2022
@IceKhan13 IceKhan13 deleted the chore/docs-guide-configuring-quantum-serverless branch November 16, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants