Create CI workflow for running a notebook test in notebook docker environment #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
…jupyter notebook container
caleb-johnson
commented
Jun 7, 2023
| run: docker compose --profile full up -d | ||
| - name: Test notebooks in the docker environment | ||
| shell: bash | ||
| run: docker exec qs-jupyter "bash" "-c" "pip install nbmake pytest && pytest --nbmake /home/jovyan/serverless/" |
There was a problem hiding this comment.
@psschwei any idea why the gateway doesnt seem to be working in the notebooks when I run these tests?
The gateway container should be up and available from line 13, I'm able to pip install the packages and run the nbmake command fine, the notebooks just fail bc they cant access gateway host
There was a problem hiding this comment.
I'm hitting a similar issue in reviewing #640 , still investigating
|
This PR is in a weird state from debugging. going to submit a fresh PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a check to the CI which loads up the full docker profile and runs a notebook test (
pytest --nbmake ...) on all of our notebooks in thedocsdir against the runningqr-jupytercontainer.Details and comments
This is a lengthy test, so it will only run on pushes to main and/or changes to docker-compose.yml/.dockerignore
I have these tests enabled on this PR, but I will enable them only for main branch before merging
Need to debug why we're getting a gateway error in notebook tests.