-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM deployment fixes #668
IBM deployment fixes #668
Conversation
infrastructure/helm/quantumserverless/charts/gateway/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
infrastructure/helm/quantumserverless/charts/gateway/values.yaml
Outdated
Show resolved
Hide resolved
hmmmm, what happened with tests? 🤔 |
let's also fix image pull policy here (I think it is set to Always right now) |
tests pass on main, though the unauthorized message pops up there as well...
edit: the PR branches passes locally now too... maybe it was just a flake? this one needs a rebase anyways, so on the next commit hopefully it rights itself |
Tests should be working fine now :) |
@Tansito can you resolve the conflicts? |
I think I solved most of the comments, @akihikokuroda , @psschwei , @IceKhan13 . I tested it and for me it's working, let me know if you find any problem. Related with:
I checked that all our policies are using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something's broken in the non IBM deploy ...
Error: INSTALLATION FAILED: template: quantum-serverless/charts/gateway/templates/deployment.yaml:75:31: executing "quantum-serverless/charts/gateway/templates/deployment.yaml" at <.Values.application.auth.token.url>: nil pointer evaluating interface {}.url
infrastructure/helm/quantumserverless/charts/gateway/templates/deployment.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor nits, but otherwise LGTM
Co-authored-by: Paul Schweigert <paul@paulschweigert.com>
Co-authored-by: Paul Schweigert <paul@paulschweigert.com>
Summary
We are preparing a deployment in IBM for this project. In our tests with discovered a couple of issues related with our current configuration that this PR tries to mitigate. List of changes:
pvc
to be used with acos
instancedeployment
configuration forgateway
to work withIQP
cos