Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM deployment fixes #668

Merged
merged 17 commits into from
Jun 14, 2023
Merged

IBM deployment fixes #668

merged 17 commits into from
Jun 14, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jun 9, 2023

Summary

We are preparing a deployment in IBM for this project. In our tests with discovered a couple of issues related with our current configuration that this PR tries to mitigate. List of changes:

  • New pvc to be used with a cos instance
  • Fixed deployment configuration for gateway to work with IQP
  • New entity in values to start working with cos

@Tansito Tansito changed the title IBM deployment IBM deployment fixes Jun 9, 2023
@IceKhan13
Copy link
Member

hmmmm, what happened with tests? 🤔

@IceKhan13
Copy link
Member

let's also fix image pull policy here (I think it is set to Always right now)

@psschwei
Copy link
Collaborator

psschwei commented Jun 9, 2023

hmmmm, what happened with tests?

tests pass on main, though the unauthorized message pops up there as well...

~/quantum/quantum-serverless/gateway on  main via 🐍 v3.9.16 (venv) 
$ tox -epy39
py39: install_deps> pip install -U -r requirements.txt -r requirements-dev.txt
py39: commands[0]> pip check
No broken requirements found.
py39: commands[1]> python manage.py test
Using selector: EpollSelector
Found 12 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
..Unauthorized: /api/v1/jobs/
..GET http://test_user-head-svc:8265/ 200
.....Unauthorized: /api/v1/programs/
...
----------------------------------------------------------------------
Ran 12 tests in 3.601s

OK
Destroying test database for alias 'default'...
  py39: OK (33.63=setup[27.66]+cmd[0.76,5.21] seconds)
  congratulations :) (33.75 seconds)

edit: the PR branches passes locally now too... maybe it was just a flake? this one needs a rebase anyways, so on the next commit hopefully it rights itself

@IceKhan13
Copy link
Member

Tests should be working fine now :)
Fixed in 3d7b0c7

@pacomf
Copy link
Member

pacomf commented Jun 12, 2023

@Tansito can you resolve the conflicts?

@Tansito
Copy link
Member Author

Tansito commented Jun 14, 2023

I think I solved most of the comments, @akihikokuroda , @psschwei , @IceKhan13 . I tested it and for me it's working, let me know if you find any problem. Related with:

let's also fix image pull policy here (I think it is set to Always right now)

I checked that all our policies are using IfNotPresent.

Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's broken in the non IBM deploy ...


Error: INSTALLATION FAILED: template: quantum-serverless/charts/gateway/templates/deployment.yaml:75:31: executing "quantum-serverless/charts/gateway/templates/deployment.yaml" at <.Values.application.auth.token.url>: nil pointer evaluating interface {}.url

@Tansito Tansito requested a review from psschwei June 14, 2023 14:33
Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor nits, but otherwise LGTM

infrastructure/helm/quantumserverless/values.yaml Outdated Show resolved Hide resolved
infrastructure/helm/quantumserverless/values-ibm.yaml Outdated Show resolved Hide resolved
Tansito and others added 2 commits June 14, 2023 16:46
Co-authored-by: Paul Schweigert <paul@paulschweigert.com>
Co-authored-by: Paul Schweigert <paul@paulschweigert.com>
@Tansito Tansito merged commit a98fad6 into main Jun 14, 2023
@Tansito Tansito deleted the deployment-improvements-v2 branch June 14, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants