Prepull ray images to all cluster nodes #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
infrastructure/helm/quantumserverless/templates/image-prepuller-daemonset.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
|
It may be too much but I wonder if we want to enable node selector or node affinity in the values.yaml file in some environment. |
|
I'd think I'd lean towards too much for now, unless there's a specific use case that needs it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #728
Add a daemonset to prepull the ray images to all nodes in the cluster.
Details and comments
A daemonset ensures that all nodes run a copy of a pod. Our daemonset is set up using the ray node (using the value from the gateway ray image key) as an init container and the google "pause" container as the main one (the "pause" container more or less just sleeps and has minimal footprint). By using a daemonset, we ensure that anytime a new node is added to the cluster, the ray image will be pulled to it.