Execute CI with a new release #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
commented
Jul 7, 2023
psschwei
reviewed
Jul 10, 2023
Comment on lines
+43
to
+46
| - name: Set version from tag | ||
| if : github.event_name == 'release' && github.event.action == 'published' | ||
| id: set-version-from-tag | ||
| run: echo "VERSION=${GITHUB_REF_NAME/v}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
nit: should we set this in the build and push images action? (just a thought, might make it easier to follow the flow, but I could go either way...)
There was a problem hiding this comment.
I see you point. Mmm... Right now in the action we have and input called tag that can have different values. We are using latest and the specific release version as values on it, depending of the action. I would say in this case at least from my point of view I would prefer the reusability that we have that introduce that value in the action (totally my opinion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we are starting to release more often I wanted to improve our DX. With this PR the idea is that once time we publish a release all the required workloads run automatically, without an action from our part.