Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantumserverless rename #786

Merged
merged 4 commits into from
Jul 20, 2023
Merged

quantumserverless rename #786

merged 4 commits into from
Jul 20, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jul 17, 2023

Summary

Fix #780 , #779

This PR pretends to standardize the use of quantum-serverless instead of quantumserverless.

@akihikokuroda
Copy link
Collaborator

I think that some changes need in infrastructure/helm/quantum-serverless/templates/keycloakrealm.yaml file.

@psschwei
Copy link
Collaborator

This failed when running on kubernetes:

INFO 2023-07-17 14:15:52,403 update_jobs_statuses.py:57 : Job [cae382c9-d1ba-4b7f-b87a-5a0e1abbcafa] status changed from [PENDING] to [FAILED]

(of course the ray pods shut down before I checked their logs, to be continued...)

@psschwei
Copy link
Collaborator

nothing in the ray pods, keycloak, or scheduler to indicate why it failed... 🤷

@akihikokuroda
Copy link
Collaborator

akihikokuroda commented Jul 18, 2023

@psschwei @Tansito I fetched this branch, update dependencies and rebuilt all images. After that it is working fine for me.

@psschwei
Copy link
Collaborator

Could very well have been something local to my end... if it's working for others, then we should be good to go.

@Tansito Tansito marked this pull request as ready for review July 19, 2023 08:34
@Tansito
Copy link
Member Author

Tansito commented Jul 19, 2023

I tested it too with one of the programs and for me it's working.

Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tansito Tansito merged commit f2b8ac5 into main Jul 20, 2023
@Tansito Tansito deleted the qs-rename branch July 20, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename quantumserverless to quantum-serverless
4 participants