Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway: coverage improvements #814

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Gateway: coverage improvements #814

merged 4 commits into from
Jul 25, 2023

Conversation

IceKhan13
Copy link
Member

@IceKhan13 IceKhan13 commented Jul 20, 2023 •
edited
Loading

Summary

Improvements in code coverage and some code deduplication.

  • enable coverage report in ci and test for 70%
  • tests for commands and custom auth
  • small refactor of retry logic

Details and comments

Part of #316

@IceKhan13
Copy link
Member Author

IceKhan13 commented Jul 24, 2023 •
edited
Loading

Some prep work for Scott. Increased Coverage from 25% to 73%.

In following PRs we will need to increate coverage >90% and include tests for fails.

@IceKhan13 IceKhan13 marked this pull request as ready for review July 24, 2023 19:39
@IceKhan13 IceKhan13 added this to the 0.4 milestone Jul 24, 2023
akihikokuroda
akihikokuroda approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IceKhan13 IceKhan13 merged commit 3ff2a1b into main Jul 25, 2023
@IceKhan13 IceKhan13 deleted the chore/coverage-improvements branch July 25, 2023 15:25
@IceKhan13 IceKhan13 mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei approved these changes

@akihikokuroda akihikokuroda akihikokuroda approved these changes

@pacomf pacomf pacomf approved these changes

@Tansito Tansito Awaiting requested review from Tansito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@IceKhan13 @pacomf @akihikokuroda @psschwei