Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox as development requirement #856

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

psschwei
Copy link
Collaborator

@psschwei psschwei commented Aug 3, 2023

Fixes #854

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psschwei ! One question here, should we start pinning versions even for dev requirements, @IceKhan13 , @psschwei ?

@psschwei
Copy link
Collaborator Author

psschwei commented Aug 4, 2023

should we start pinning versions even for dev requirements

🤔 pinning makes things more reproducible / stable, but these are for building, so it might also be nice to be bleeding edge and/or pick up patches/fixes a little quicker ... I could go either way

@Tansito
Copy link
Member

Tansito commented Aug 4, 2023

Well, in general we are relatively fast with updates with renovate. From time to time we got stuck in a version but I suppose it's something common. I don't have a strong opinion, either (feel free to merge it).

@psschwei
Copy link
Collaborator Author

psschwei commented Aug 4, 2023

Let's merge this and then pin them
(I did notice some weird stuff with using the most recent version of tox, which is why I had to do f66909b ... but I don't seem to be able to find the failed tests right now for some reason)

@psschwei psschwei merged commit e5ff34a into Qiskit:main Aug 4, 2023
@psschwei psschwei deleted the add-tox branch August 4, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox is not listed as a requirement anywhere
3 participants