Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 83 | Docker-compose: regular and dev files #89

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

IceKhan13
Copy link
Member

Summary

Docker-compose: regular and dev files

Details and comments

Closes #83

@IceKhan13 IceKhan13 added the enhancement New feature or request label Dec 16, 2022
@IceKhan13 IceKhan13 requested review from pacomf and Tansito December 16, 2022 14:53
@IceKhan13 IceKhan13 added this to the 0.1.0 milestone Dec 16, 2022
networks:
- safe-tier
redis:
image: 'bitnami/redis:latest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about why are we using here bitnami image and not the official one?

Copy link
Member Author

@IceKhan13 IceKhan13 Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It had better documentation :) and Bitnami usually do good job on optimizing stuff

But really it does not matter that much

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha ok, good reason 😂

@Tansito Tansito self-requested a review December 16, 2022 15:06
@IceKhan13 IceKhan13 merged commit aa1ef8f into main Dec 16, 2022
@IceKhan13 IceKhan13 deleted the issue-83/docker-compose-files branch December 16, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dev and regular docker-compose files
3 participants