Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Update RB notebooks #885

Closed
wants to merge 7 commits into from
Closed

Conversation

ShellyGarion
Copy link
Member

Summary

Updating RB tutorials following API changes in ignis.

Details and comments

qiskit-community/qiskit-ignis#334

@nkanazawa1989
Copy link
Contributor

LGTM. just one small comment

the description above cell 14 should be updated because it doesn't take qobj.

The function gates_per_clifford takes a compiled qobj and outputs the number of basis gates in each circuit.

@nonhermitian
Copy link
Contributor

Note that all the tutorials now go in the Qiskit documentation: https://github.com/Qiskit/qiskit

@ShellyGarion
Copy link
Member Author

Note that all the tutorials now go in the Qiskit documentation: https://github.com/Qiskit/qiskit

Thanks, so I'll close this PR when I will open a new one in the right place.

@ShellyGarion
Copy link
Member Author

@nkanazawa1989 - could you please review the updated notebook?
when it's done, then I'll close this PR and move the notebook to qiskit docs.

@nkanazawa1989
Copy link
Contributor

looks good. one minor suggestion: cell 14 can be simplified

for basis_gate in basis_gates:
    print("Number of %s gates per Clifford: %f "%(basis_gate ,
                                                  np.mean([gates_per_cliff[0][basis_gate],
                                                           gates_per_cliff[2][basis_gate]])))

because gates_per_cliff is dictionary.

and the PR should be on hold until ignis 0.3 is released.

@ShellyGarion
Copy link
Member Author

Opened a new PR in qiskit docs: Qiskit/qiskit#866

@ShellyGarion ShellyGarion changed the title [WIP] update RB notebooks Update RB notebooks Apr 29, 2020
@ShellyGarion
Copy link
Member Author

Fix #892.

@ShellyGarion
Copy link
Member Author

Closing since notebook 5a was moved to 4, and 5d was removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants