Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Working version of the old tomography tutorial #973

Closed
wants to merge 7 commits into from

Conversation

gadial
Copy link
Contributor

@gadial gadial commented Jul 30, 2020

Summary

This PR returns to qiskit-tutorials the tomography tutorial that was once part of it, but was removed due to run failures.

Details and comments

This version should work with the most up-to-date version of Qiskit, given a correct installation of cvxpy, which means it was correctly linked with blas and lapack; othewise running will result in an error about the SCS engine being unable to solve SDP's.

@nonhermitian
Copy link
Contributor

Seems like the original issue still occurs here as it is failing with a SCS error.

@gadial
Copy link
Contributor Author

gadial commented Aug 2, 2020

Seems like the original issue still occurs here as it is failing with a SCS error.

Unfortunately that's not the original issue (which was state_fidelity failing due to missing validate=False argument) but something new and much more troublesome which affects Ingis in general.

@chriseclectic
Copy link
Member

You need to install cvxopt in the doc build environment (@mtreinish)

@nonhermitian
Copy link
Contributor

There are some formatting issues in the rendered docs:

Screen Shot 2020-08-06 at 15 38 17

Screen Shot 2020-08-06 at 15 38 31

Also not sure about this:

Screen Shot 2020-08-06 at 15 39 38

@gadial
Copy link
Contributor Author

gadial commented Aug 13, 2020

There are some formatting issues in the rendered docs:

I fixed the rendering issue. As to the "FATAL: cannot solve SDP", sadly this is the expected behavior - currently Ignis performs a test run to check whether some engine can be used; if it cannot, it uses another, but in the process this "FATAL" message is sent. We need to fix this inside Ignis itself.

@nonhermitian
Copy link
Contributor

It seems that the PR includes changes to 21 different files. Can this be trimmed down to include only the tomography tutorial. Otherwise, a list of changes to the other files should be given as well. Otherwise, the tomo one looks good to go.

@gadial
Copy link
Contributor Author

gadial commented Aug 13, 2020

It seems that the PR includes changes to 21 different files. Can this be trimmed down to include only the tomography tutorial. Otherwise, a list of changes to the other files should be given as well. Otherwise, the tomo one looks good to go.

This is due to some rebase problem I couldn't fix. I think I'll have to create a new PR with the fixed notebook.

@gadial gadial closed this Aug 13, 2020
@gadial gadial deleted the tomography_tutorial branch August 13, 2020 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants