Remove tweedledum as a core dependency (#8947)

* Remove tweedledum as a core dependency

Maintenance on tweedledum has stagnated in recent months, and is no
longer stable enough on our Tier-1 (and other) supported platforms,
especially as further Python versions are released.  This work was
heralded by gh-8738, which contains more context on the change.

* Add tweedledum pylint suppressions

I couldn't get `.pylintrc`'s `ignore{,d}-modules` options to work right
for this, so I just resorted to localised suppressions.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

qiskit/circuit/classicalfunction/__init__.py

@@ -9,6 +9,7 @@
 # Any modifications or derivative works of this code must retain this
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
+
 """
 ====================================================================
 ClassicalFunction compiler (:mod:`qiskit.circuit.classicalfunction`)
@@ -97,9 +98,9 @@ def grover_oracle(a: Int1, b: Int1, c: Int1, d: Int1) -> Int1:
 
 """
 
-from qiskit.utils import optionals as _optionals
+from qiskit.utils.optionals import HAS_TWEEDLEDUM
 
-_optionals.HAS_TWEEDLEDUM.require_now("classical oracle creation")
+HAS_TWEEDLEDUM.require_now("classical function oracles")
 
 # pylint: disable=wrong-import-position
 

qiskit/circuit/classicalfunction/boolean_expression.py

@@ -15,8 +15,8 @@
 from os.path import basename, isfile
 from typing import Callable, Optional
 
-from tweedledum import BitVec, BoolFunction
-from tweedledum.synthesis import pkrm_synth
+from tweedledum import BitVec, BoolFunction  # pylint: disable=import-error
+from tweedledum.synthesis import pkrm_synth  # pylint: disable=import-error
 
 from qiskit.circuit import QuantumCircuit
 from .classical_element import ClassicalElement

qiskit/circuit/classicalfunction/classical_function_visitor.py

@@ -17,7 +17,7 @@
 import ast
 import _ast
 
-from tweedledum.classical import LogicNetwork
+from tweedledum.classical import LogicNetwork  # pylint: disable=import-error
 
 from .exceptions import ClassicalFunctionParseError, ClassicalFunctionCompilerTypeError
 

qiskit/circuit/classicalfunction/classicalfunction.py

@@ -15,8 +15,8 @@
 import ast
 from typing import Callable, Optional
 
-from tweedledum.classical import simulate
-from tweedledum.synthesis import pkrm_synth
+from tweedledum.classical import simulate  # pylint: disable=import-error
+from tweedledum.synthesis import pkrm_synth  # pylint: disable=import-error
 
 from qiskit.circuit import QuantumCircuit, QuantumRegister
 from qiskit.exceptions import QiskitError

qiskit/circuit/classicalfunction/utils.py

@@ -12,8 +12,8 @@
 
 """Internal utils for Classical Function Compiler"""
 
-from tweedledum.ir import Qubit
-from tweedledum.passes import parity_decomp
+from tweedledum.ir import Qubit  # pylint: disable=import-error
+from tweedledum.passes import parity_decomp  # pylint: disable=import-error
 
 
 from qiskit.circuit import QuantumCircuit

qiskit/circuit/library/phase_oracle.py

@@ -71,7 +71,7 @@ def __init__(
         if synthesizer is None:
 
             def synthesizer(boolean_expression):
-                from tweedledum.synthesis import pkrm_synth
+                from tweedledum.synthesis import pkrm_synth  # pylint: disable=import-error
                 from qiskit.circuit.classicalfunction.utils import tweedledum2qiskit
 
                 truth_table = boolean_expression._tweedledum_bool_expression.truth_table(

releasenotes/notes/remove-tweedledum-0f21ca327a782bc3.yaml

@@ -0,0 +1,14 @@
+---
+upgrade:
+  - |
+    ``tweedledum`` has been removed as a core requirement of Qiskit Terra.  The
+    functionality provided (:mod:`qiskit.circuit.classicalfunction`) is still
+    available, if ``tweedledum`` is installed manually, such as by:
+
+      .. code-block:: text
+
+      pip install tweedledum
+
+    This change was made because ``tweedledum`` development has slowed to the
+    point of not keeping up with new Python and OS releases, and was blocking
+    some Qiskit users from installing Qiskit.

requirements.txt

@@ -12,10 +12,6 @@ shared-memory38;python_version<'3.8'
 typing-extensions; python_version < '3.8'
 singledispatchmethod; python_version < '3.8'
 
-# To be removed as a requirement in Terra 0.23.  Tweedledum's wheels are
-# hopelessly broken on M1 mac, so we skip the waiting period for that.
-tweedledum>=1.1,<2.0; platform_machine != 'arm64' or sys_platform != 'darwin'
-
 # Hack around stevedore being broken by importlib_metadata 5.0; we need to pin
 # the requirements rather than the constraints if we need to cut a release
 # before stevedore is fixed.  `importlib_metadata` is not (currently) a direct

test/python/classical_function_compiler/test_tweedledum2qiskit.py

@@ -20,6 +20,7 @@
 from qiskit.circuit.library.standard_gates import XGate
 
 if HAS_TWEEDLEDUM:
+    # pylint: disable=import-error
     from qiskit.circuit.classicalfunction.utils import tweedledum2qiskit
 
     from tweedledum.ir import Circuit