Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining standard gates to rust representation #12566

Closed
35 of 38 tasks
mtreinish opened this issue Jun 13, 2024 · 3 comments · Fixed by #12709
Closed
35 of 38 tasks

Add remaining standard gates to rust representation #12566

mtreinish opened this issue Jun 13, 2024 · 3 comments · Fixed by #12709
Assignees
@jlapeyre @mtreinish @eliarbel @ElePT
Labels
performance Rust This PR or issue is related to Rust code in the repository type: feature request New feature or request
Milestone
1.2.0

Comments

@mtreinish
Copy link
Member

mtreinish commented Jun 13, 2024 •
edited by ElePT
Loading

What should we add?

After #12459 has merged there is now a native rust representation of the standard gate library. However, due to the size of #12459 not all gates were added to this rust representation. This issue tracks the migration of the remaining gates so that we have the complete standard gate library in rust. The remaining gates are:

Tasks
Beta Give feedback
@mtreinish mtreinish added type: feature request New feature or request performance Rust This PR or issue is related to Rust code in the repository labels Jun 13, 2024
@mtreinish mtreinish added this to the 1.2.0 milestone Jun 13, 2024
mtreinish added a commit to mtreinish/qiskit-core that referenced this issue Jun 13, 2024
@mtreinish
Add rust representation for the u1, u2, and u3 gates
dce2b20 
This commit adds the rust representation of the U1Gate, U2Gate, and
U3Gate to the `StandardGates` enum in rust.

Part of Qiskit#12566
@mtreinish mtreinish mentioned this issue Jun 13, 2024
Merged
mtreinish added a commit to mtreinish/qiskit-core that referenced this issue Jun 14, 2024
@mtreinish
Add rust representation for the u1, u2, and u3 gates
afad78d 
This commit adds the rust representation of the U1Gate, U2Gate, and
U3Gate to the `StandardGates` enum in rust.

Part of Qiskit#12566
@ElePT
Copy link
Contributor

ElePT commented Jun 18, 2024 •
edited by jlapeyre
Loading

EDIT: All done now.
I will give a try to the following gates with the following indices in the table:

  • SGate -> 21
  • SdgGate -> 22
  • iSwapGate -> 23
  • SXGate -> 24
  • SXdgGate -> 25
  • TGate -> 26
  • TdgGate -> 27

@ElePT ElePT mentioned this issue Jun 18, 2024
Merged
@ElePT ElePT mentioned this issue Jun 19, 2024
Merged
mtreinish added a commit to mtreinish/qiskit-core that referenced this issue Jun 21, 2024
@mtreinish
Add rust representation for the u1, u2, and u3 gates
da90e25 
This commit adds the rust representation of the U1Gate, U2Gate, and
U3Gate to the `StandardGates` enum in rust.

Part of Qiskit#12566
@eliarbel eliarbel mentioned this issue Jun 24, 2024
Merged
This was referenced Jun 24, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 24, 2024
@mtreinish @ElePT
Add rust representation for the u1, u2, and u3 gates (#12572)
bf8f398 
* Add rust representation for the u1, u2, and u3 gates

This commit adds the rust representation of the U1Gate, U2Gate, and
U3Gate to the `StandardGates` enum in rust.

Part of #12566

* Update crates/circuit/src/imports.rs

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* Fix test failures

* Fix pylint pedantry

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
@Cryoris Cryoris mentioned this issue Jun 24, 2024
Merged
@ElePT ElePT mentioned this issue Jun 25, 2024
Merged
@eliarbel
Copy link
Contributor

Is MSGate here by accident?

@eliarbel eliarbel mentioned this issue Jun 27, 2024
Merged
@mtreinish
Copy link
Member Author

I just copied this from the list in the python code. We can skip MSGate since it shouldn't matter unless we need to generate it from Rust. Since it's mostly there for backwards compatibility and has been superseded by GMS we don't need to worry about it for this issue. It'll be easy to add in the future if the need arises.

@ElePT ElePT mentioned this issue Jul 2, 2024
Merged
@mtreinish mtreinish linked a pull request Jul 2, 2024 that will close this issue
Finalize Rust representation for standard gates #12709
Merged
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this issue Aug 1, 2024
@mtreinish @ElePT @Procatv
Add rust representation for the u1, u2, and u3 gates (Qiskit#12572)
d1590e9 
* Add rust representation for the u1, u2, and u3 gates

This commit adds the rust representation of the U1Gate, U2Gate, and
U3Gate to the `StandardGates` enum in rust.

Part of Qiskit#12566

* Update crates/circuit/src/imports.rs

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* Fix test failures

* Fix pylint pedantry

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlapeyre jlapeyre

@mtreinish mtreinish

@eliarbel eliarbel

@ElePT ElePT

Labels
performance Rust This PR or issue is related to Rust code in the repository type: feature request New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Finalize Rust representation for standard gates ElePT/qiskit
4 participants
@jlapeyre @mtreinish @eliarbel @ElePT