Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circuit calibrations to disassembler #5348

Closed
lcapelluto opened this issue Nov 5, 2020 · 8 comments
Closed

Add circuit calibrations to disassembler #5348

lcapelluto opened this issue Nov 5, 2020 · 8 comments
Assignees
Labels
good first issue Good for newcomers help wanted community contributions welcome. For filters like http://github-help-wanted.com/ mod: pulse Related to the Pulse module type: enhancement It's working, but needs polishing

Comments

@lcapelluto
Copy link
Contributor

What is the expected enhancement?

Right now, pulse gates are not parsed by the disassembler. To fix this, qobj.config.calibrations would have to be parsed per job, and every qobj.experiment would have to be checked for config.calibrations as well. Each circuit would need every job cal, and its own experiment cals. Experiment cals overwrite job cals. Pulse instructions in each calibration would have to be disassembled, with input from qobj.config.pulse_library.

All changes should be made in disassemble.py. Methods from qobj/converters/pulse_instruction.py will likely be useful.

@lcapelluto lcapelluto added type: enhancement It's working, but needs polishing good first issue Good for newcomers help wanted community contributions welcome. For filters like http://github-help-wanted.com/ labels Nov 5, 2020
@edcohen08
Copy link

Hi, I would like to try this. Is the goal to return a list of circuits similar to _experiments_to_circuits or something else?

@lcapelluto
Copy link
Contributor Author

Hi, I'm just seeing your message. Are you still interested?

@areeq-hasan
Copy link
Contributor

I'd love to work on this issue as well!

@lcapelluto
Copy link
Contributor Author

@Ahasan20 Thank you! Although I did label it "good first issue", it'll be a bit challenging. Feel free to DM me on Qiskit slack if you need help.

@1ucian0
Copy link
Member

1ucian0 commented Mar 19, 2021

Hi @Ahasan20 any progress?

@areeq-hasan
Copy link
Contributor

hey @1ucian0 yup i've been working on it here: #5661, dev's been a bit slow with college but we're getting there!

@fs1132429
Copy link
Contributor

I am new to contributing but I would like to contribute to this if its ok.

@jakelishman
Copy link
Member

Closed by #5661.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted community contributions welcome. For filters like http://github-help-wanted.com/ mod: pulse Related to the Pulse module type: enhancement It's working, but needs polishing
Projects
None yet
Development

No branches or pull requests

6 participants