Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circuit calibrations to disassembler #5661

Merged
merged 85 commits into from
Jul 15, 2021
Merged

Add circuit calibrations to disassembler #5661

merged 85 commits into from
Jul 15, 2021

Conversation

areeq-hasan
Copy link
Contributor

Summary

disassembled circuits now inherit calibrations from assembled qobj and experiment.

Details and comments

_qobj_to_circuit_cals(qobj_cals) parses qobj and experiment calibrations into the circuit calibration dict structure.
_experiments_to_circuits sets circuit calibrations, first from qobj-level and second from experiment-level, if calibrations were assigned.

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2021

CLA assistant check
All committers have signed the CLA.

@lcapelluto lcapelluto self-assigned this Jan 21, 2021
@areeq-hasan areeq-hasan requested a review from lcapelluto May 25, 2021 01:24
Copy link
Contributor

@lcapelluto lcapelluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my earlier comments was lost, but I'd still like it addressed. No new comments, though, it's nearly ready!

test/python/compiler/test_disassembler.py Outdated Show resolved Hide resolved
test/python/compiler/test_disassembler.py Outdated Show resolved Hide resolved
@areeq-hasan areeq-hasan requested a review from lcapelluto July 14, 2021 03:37
areeq-hasan and others added 2 commits July 15, 2021 12:22
lcapelluto
lcapelluto previously approved these changes Jul 15, 2021
Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
@lcapelluto lcapelluto added automerge Changelog: New Feature Include in the "Added" section of the changelog Changelog: Bugfix Include in the "Fixed" section of the changelog and removed Changelog: New Feature Include in the "Added" section of the changelog labels Jul 15, 2021
@lcapelluto
Copy link
Contributor

Closes #5348

@mergify mergify bot merged commit 9b48476 into Qiskit:main Jul 15, 2021
@kdk kdk added this to the 0.19 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants