-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add circuit calibrations to disassembler #5661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calibrations for experiment case
Calibration check, top level
areeq-hasan
requested review from
DanPuzzuoli,
eggerdj,
lcapelluto,
nkanazawa1989,
taalexander and
a team
as code owners
January 21, 2021 00:39
This reverts commit 400c8e3.
updated experiments_to_circuits()
lcapelluto
suggested changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of my earlier comments was lost, but I'd still like it addressed. No new comments, though, it's nearly ready!
lcapelluto
reviewed
Jul 15, 2021
Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
lcapelluto
previously approved these changes
Jul 15, 2021
lcapelluto
reviewed
Jul 15, 2021
Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
lcapelluto
approved these changes
Jul 15, 2021
lcapelluto
added
automerge
Changelog: New Feature
Include in the "Added" section of the changelog
Changelog: Bugfix
Include in the "Fixed" section of the changelog
and removed
Changelog: New Feature
Include in the "Added" section of the changelog
labels
Jul 15, 2021
Closes #5348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
disassembled circuits now inherit calibrations from assembled qobj and experiment.
Details and comments
_qobj_to_circuit_cals(qobj_cals)
parses qobj and experiment calibrations into the circuit calibration dict structure._experiments_to_circuits
sets circuit calibrations, first from qobj-level and second from experiment-level, if calibrations were assigned.