Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate visualize_transition() visualization function #9355

Closed
mtreinish opened this issue Jan 9, 2023 · 3 comments · Fixed by #12287
Closed

Deprecate visualize_transition() visualization function #9355

mtreinish opened this issue Jan 9, 2023 · 3 comments · Fixed by #12287
Assignees
@YingHongTham
Labels
good first issue Good for newcomers
Milestone
1.2.0

Comments

@mtreinish
Copy link
Member

What should we add?

The visualize_transition() has a number of limitations with it and is really outside the scope of visualizations we want to be supporting in qiskit. We should plan to deprecate and subsequently remove this function from qiskit, it can live as an external library or module for those who would like to retain this functionality moving forward.
@mtreinish mtreinish added this to the 0.24.0 milestone Jan 9, 2023
@kdk
Copy link
Member

kdk commented Jan 17, 2023

Can we include in this setting up an external repository with the existing code and moving it to https://qiskit.org/ecosystem/ ?

@1ucian0 1ucian0 mentioned this issue Mar 14, 2023
Open
@1ucian0
Copy link
Member

1ucian0 commented Mar 14, 2023

I made a feature request for it in kaleidoscope QuSTaR/kaleidoscope#67

Finding a place for the function does not have to be a blocker for this issue.

@kdk kdk removed this from the 0.24.0 milestone Apr 6, 2023
@javabster javabster mentioned this issue Apr 7, 2023
Open
@1ucian0 1ucian0 added the good first issue Good for newcomers label Mar 24, 2024
@github-project-automation github-project-automation bot moved this to Tagged but unassigned in Contributor Monitoring Mar 24, 2024
@1ucian0 1ucian0 added this to the 1.1.0 milestone Mar 24, 2024
@YingHongTham
Copy link
Contributor

@mtreinish has this issue been assigned to someone? I would like to work on it

@AngeloDanducci AngeloDanducci moved this from Tagged but unassigned to Assigned in Contributor Monitoring Apr 1, 2024
@jakelishman jakelishman modified the milestones: 1.1.0, 1.2.0 Apr 11, 2024
@YingHongTham YingHongTham mentioned this issue Apr 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 26, 2024
@YingHongTham @atharva-satpute
@mtreinish @ElePT
fixes #9355 deprecate visualize_transition (#12287)
4ec51d1 
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Assigned to Done in Contributor Monitoring Jul 26, 2024
mergify bot pushed a commit that referenced this issue Jul 26, 2024
@YingHongTham @mergify
fixes #9355 deprecate visualize_transition (#12287)
08156ed 
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
(cherry picked from commit 4ec51d1)
@mergify mergify bot mentioned this issue Jul 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 26, 2024
@mergify @YingHongTham
fixes #9355 deprecate visualize_transition (#12287) (#12822)
c0bd6fd 
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
(cherry picked from commit 4ec51d1)

Co-authored-by: YingHongTham <thamyinghong@gmail.com>
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this issue Aug 1, 2024
@YingHongTham @atharva-satpute
@mtreinish @ElePT @Procatv
fixes Qiskit#9355 deprecate visualize_transition (Qiskit#12287)
255c211 
* added deprecation warnings and decorators to transition_visualization.py

* fixed style with tox -epy310 -eblack

* added release notes

* added to warning category=DeprecationWarning and stacklevel=2

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Update releasenotes/notes/deprecate-visualize_transition-8c1d257b7f37aa58.yaml

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>

* Apply suggestions from code review

* Fix lint complaint

---------

Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YingHongTham YingHongTham

Labels
good first issue Good for newcomers
Projects
Contributor Monitoring
Status: Done
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

fixes #9355 deprecate visualize_transition YingHongTham/qiskit
5 participants
@1ucian0 @kdk @mtreinish @YingHongTham @jakelishman