Allow circuits w/ control flow in O2 and O3 #10372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
jakelishman
added
the
Changelog: New Feature
mtreinish
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Just a quick inline comment, I also think we should have some expansion of the test coverage here, places like: https://github.com/Qiskit/qiskit-terra/blob/main/test/python/compiler/test_transpiler.py#L1762, https://github.com/Qiskit/qiskit-terra/blob/main/test/python/compiler/test_transpiler.py#L1784, https://github.com/Qiskit/qiskit-terra/blob/main/test/python/compiler/test_transpiler.py#L1821, and https://github.com/Qiskit/qiskit-terra/blob/main/test/python/compiler/test_transpiler.py#L1531 would be simple enough to update the ddt decorator. But there are probably a few other control flow tests we should parameterize on multiple optimization levels with this PR.
4 tasks
kevinhartman
force-pushed
the
ctrl-flow-o2-o3
branch
from
72be488 to
2a2ae22
Compare
mtreinish
previously approved these changes
Jul 20, 2023
10 tasks
Pull Request Test Coverage Report for Build 5621665928
💛 - Coveralls |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
In CI we're seeing a reliable failure on windows when scipy is calling LAPACK. This appears to be unrelated to the change in this PR branch and is isolated to specific windows environments. This commit adds a skip condition to skip that one test to workaround the failure in CI. The wider issue with scipy compatibility on windows is being tracked in issue Qiskit#10345, when we have a conclusion to that and can reliably run this test we should remove this skip condition.
mtreinish
approved these changes
Jul 21, 2023
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
* Allow control flow in opt levels 2 and 3. * Add release note. * Enable testing for opt 2 and 3. * Remove guard on translation_method='synthesis'. * Fix test for synthesis guard. * Skip o3 qpy full path transpile test on windows In CI we're seeing a reliable failure on windows when scipy is calling LAPACK. This appears to be unrelated to the change in this PR branch and is isolated to specific windows environments. This commit adds a skip condition to skip that one test to workaround the failure in CI. The wider issue with scipy compatibility on windows is being tracked in issue Qiskit#10345, when we have a conclusion to that and can reliably run this test we should remove this skip condition. --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove guards to restrict circuits with control flow from being transpiled at optimization levels 2 and 3.
Details and comments
Depends on:
SabreSwapandSabreLayout. #10366Resolves #9431
Resolves #9432